Remove pkg resources #2871
Open
Remove pkg resources #2871
+245
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned federicobond, NathanielRN, nikosokolik, oxeye-nikolay, shalevr and srprash
xrmx
unassigned federicobond, NathanielRN, srprash, shalevr, nikosokolik and oxeye-nikolay
xrmx
force-pushed
the
remove-pkg-resources
branch
from
103df57
to
3f339c3
Compare
github-actions
bot
assigned federicobond, NathanielRN, nikosokolik, oxeye-nikolay, shalevr and srprash
xrmx
unassigned federicobond, NathanielRN, srprash, shalevr, nikosokolik and oxeye-nikolay
xrmx
commented
Sep 13, 2024
instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py
Outdated
Show resolved
Hide resolved
xrmx
force-pushed
the
remove-pkg-resources
branch
from
854b02a
to
4a8055f
Compare
…tadata from requiements
|
Tested out locally and it works for me. My benchmarks show a ~100-200ms improvement in the import/start time when manually configuring and ~400-500ms when using the auto-instrumentation. Thank you to everyone who contributed towards this change and I can't wait to see this land 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This incorporates all previous work from @Rodrigo-Novas and @ocelotl and makes ci happy.
Fixes #2180
Fixes #1970
Fixes #2843
Closes #1973 #2124 #2181 #2854
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.